Skip to content

Set AsusWRT mac_address and ip_address properties#48764

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bieniu:asuswrt-properties
Apr 7, 2021
Merged

Set AsusWRT mac_address and ip_address properties#48764
MartinHjelmare merged 2 commits intohome-assistant:devfrom
bieniu:asuswrt-properties

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Apr 7, 2021

Breaking change

The device_tracker entity state attribute ip_address has been changed to be named ip. Users should update automations and scripts that use this attribute.

Proposed change

According to the documentation, mac_address and ip_address should be properties, not attributes. This PR change this.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/asuswrt/device_tracker.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a breaking change paragraph.

Comment thread homeassistant/components/asuswrt/device_tracker.py
@MartinHjelmare MartinHjelmare changed the title Return mac_address and ip_address as properties in AsusWRT integration Set AsusWRT mac_address and ip_address properties Apr 7, 2021
@MartinHjelmare MartinHjelmare merged commit 5be1eac into home-assistant:dev Apr 7, 2021
@bieniu bieniu deleted the asuswrt-properties branch April 7, 2021 10:09
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants